commit 35b2bf14252112b3a60ac58b42eadd60a772ad56
author Goutham Pacha Ravi <gouthampravi@gmail.com> Thu Mar 17 00:53:45 2022 +0530
committer Goutham Pacha Ravi <gouthampravi@gmail.com> Thu Mar 17 00:53:45 2022 +0530
tree 603e6b3f06e59dea61e4b77d6ed276a741ce8dbe
parent 669e92c68e963089213d3deb8734ef61c6d6e9d9

Fix NoSuchOptError wrt CONF.validation.ssh_key_type

This option isn't available in older versions of tempest,
since manila-tempest-plugin is branchless, we will need to
handle this situation gracefully.

Currently, all scenario tests with stable/train are failing.
Sample failure: https://paste.opendev.org/show/b9HiHJHTNbtL1z6Emnpe/

Change-Id: I36d5b5a32f27065c42e31ff231c55fc16bf18fda
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

manila_tempest_tests/common/remote_client.py

diff --git a/manila_tempest_tests/common/remote_client.py b/manila_tempest_tests/common/remote_client.py
index a6eee45..573cdd6 100644
--- a/manila_tempest_tests/common/remote_client.py
+++ b/manila_tempest_tests/common/remote_client.py
@@ -71,8 +71,13 @@
         self.servers_client = servers_client
         self.log_console = CONF.compute_feature_enabled.console_output
         kwargs = {}
-        if CONF.validation.ssh_key_type:
+
+        try:
             kwargs['ssh_key_type'] = CONF.validation.ssh_key_type
+        except Exception:
+            # Not all versions of tempest support the
+            # "validation.ssh_key_type" config option
+            pass
 
         self.ssh_client = ssh.Client(
             ip_address, username, password, pkey=pkey, **kwargs)