Make _create_loginable_secgroup public
As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
_create_loginable_secgroup method isn't ready to be deleted yet, because its rulesets differs from tempest's. This method will be public now, so replaced methods will use this method over the tempest's one. Tempest doesn't allow to modify rulesets, but patch that will allow this is already proposed[2]. Some time after merging the mentioned tempest patch this plugin's implementation will be replaced.
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
[2] https://review.opendev.org/c/openstack/tempest/+/835018
Change-Id: I6b61d810c4695ac4709173a69f1b920b7228a1d0
diff --git a/manila_tempest_tests/tests/scenario/manager.py b/manila_tempest_tests/tests/scenario/manager.py
index 213e7ac..30a94fb 100644
--- a/manila_tempest_tests/tests/scenario/manager.py
+++ b/manila_tempest_tests/tests/scenario/manager.py
@@ -202,7 +202,7 @@
tenant_id=tenant_id)
# Add rules to the security group
- rules = self._create_loginable_secgroup_rule(
+ rules = self.create_loginable_secgroup_rule(
security_group_rules_client=security_group_rules_client,
secgroup=secgroup,
security_groups_client=security_groups_client)
@@ -302,9 +302,9 @@
return sg_rule
- def _create_loginable_secgroup_rule(self, security_group_rules_client=None,
- secgroup=None,
- security_groups_client=None):
+ def create_loginable_secgroup_rule(self, security_group_rules_client=None,
+ secgroup=None,
+ security_groups_client=None):
"""Create loginable security group rule
This function will create: