Merge "remove unicode prefix from code"
diff --git a/manila_tempest_tests/tests/api/admin/test_admin_actions_negative.py b/manila_tempest_tests/tests/api/admin/test_admin_actions_negative.py
index 4e72e33..3bf86ee 100644
--- a/manila_tempest_tests/tests/api/admin/test_admin_actions_negative.py
+++ b/manila_tempest_tests/tests/api/admin/test_admin_actions_negative.py
@@ -82,8 +82,11 @@
@decorators.idempotent_id('3b525c29-b657-493f-aa41-b17676a95fd2')
@tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)
def test_try_reset_share_state_with_member(self):
- # Even if member from another tenant, it should be unauthorized
- self.assertRaises(lib_exc.Forbidden,
+ # NOTE(gouthamr): The client used below is of a member from another
+ # project. As a fix to bug #1901210, the server responds with
+ # 404 instead of 403, but we'll test for one of the two codes since
+ # the test could be running against a release without the fix.
+ self.assertRaises((lib_exc.Forbidden, lib_exc.NotFound),
self.member_client.reset_state,
self.share["id"])
diff --git a/manila_tempest_tests/tests/api/admin/test_share_types.py b/manila_tempest_tests/tests/api/admin/test_share_types.py
index 3d46c9e..abdb4ba 100644
--- a/manila_tempest_tests/tests/api/admin/test_share_types.py
+++ b/manila_tempest_tests/tests/api/admin/test_share_types.py
@@ -113,22 +113,26 @@
@utils.skip_if_microversion_not_supported("2.50")
@decorators.idempotent_id('a9af19e1-e789-4c4f-a39b-dd8df6ed00b1')
@tc.attr(base.TAG_POSITIVE, base.TAG_API)
- @ddt.data(
- ('2.50', data_utils.rand_name("type_updated"),
+ @ddt.named_data(
+ ('2.50_name_description_public', '2.50',
+ data_utils.rand_name("type_updated"), 'description_updated', True),
+ ('2.50_name', '2.50', data_utils.rand_name("type_updated"), None,
+ None),
+ ('2.50_description_public', '2.50', None, 'description_updated',
+ None),
+ ('2.50_public', '2.50', None, None, True),
+ ('2.50', '2.50', None, None, False),
+ (f'{LATEST_MICROVERSION}_name_description_public',
+ LATEST_MICROVERSION, data_utils.rand_name("type_updated"),
'description_updated', True),
- ('2.50', data_utils.rand_name("type_updated"), None, None),
- ('2.50', None, 'description_updated', None),
- ('2.50', None, None, True),
- ('2.50', None, None, False),
- (LATEST_MICROVERSION, data_utils.rand_name("type_updated"),
- 'description_updated', True),
- (LATEST_MICROVERSION, data_utils.rand_name("type_updated"),
- None, None),
- (LATEST_MICROVERSION, None, 'description_updated', None),
- (LATEST_MICROVERSION, None, None, True),
- (LATEST_MICROVERSION, None, None, False),
+ (f'{LATEST_MICROVERSION}_name', LATEST_MICROVERSION,
+ data_utils.rand_name("type_updated"), None, None),
+ (f'{LATEST_MICROVERSION}_description', LATEST_MICROVERSION, None,
+ 'description_updated', None),
+ (f'{LATEST_MICROVERSION}_public', LATEST_MICROVERSION, None, None,
+ True),
+ (LATEST_MICROVERSION, LATEST_MICROVERSION, None, None, False),
)
- @ddt.unpack
def test_share_type_create_update(self, version, st_name,
st_description, st_is_public):
name = data_utils.rand_name("tempest-manila")
diff --git a/manila_tempest_tests/tests/api/test_share_types_negative.py b/manila_tempest_tests/tests/api/test_share_types_negative.py
index 046af45..3b930f9 100644
--- a/manila_tempest_tests/tests/api/test_share_types_negative.py
+++ b/manila_tempest_tests/tests/api/test_share_types_negative.py
@@ -83,15 +83,17 @@
@utils.skip_if_microversion_not_supported("2.50")
@decorators.idempotent_id('4a22945c-8988-43a1-88c9-eb86e6abcd8e')
@tc.attr(base.TAG_NEGATIVE, base.TAG_API)
- @ddt.data(
- ('2.50', '', None, None),
- (LATEST_MICROVERSION, '', None, None),
- ('2.50', None, None, 'not_bool'),
- (LATEST_MICROVERSION, None, None, 'not_bool'),
- ('2.50', None, generate_long_description(256), None),
- (LATEST_MICROVERSION, None, generate_long_description(256), None),
+ @ddt.named_data(
+ ('2.50', '2.50', '', None, None),
+ (LATEST_MICROVERSION, LATEST_MICROVERSION, '', None, None),
+ ('2.50_bad_public', '2.50', None, None, 'not_bool'),
+ (f'{LATEST_MICROVERSION}_bad_public', LATEST_MICROVERSION, None, None,
+ 'not_bool'),
+ ('2.50_description', '2.50', None, generate_long_description(256),
+ None),
+ (f'{LATEST_MICROVERSION}_description', LATEST_MICROVERSION, None,
+ generate_long_description(256), None),
)
- @ddt.unpack
def test_share_type_update_bad_request(
self, version, st_name, st_description, st_is_public):
st_id = self.st['id']
diff --git a/manila_tempest_tests/tests/api/test_shares_actions_negative.py b/manila_tempest_tests/tests/api/test_shares_actions_negative.py
index a600b8e..977d9a1 100644
--- a/manila_tempest_tests/tests/api/test_shares_actions_negative.py
+++ b/manila_tempest_tests/tests/api/test_shares_actions_negative.py
@@ -340,8 +340,11 @@
share = self.create_share(share_type_id=self.share_type_id,
cleanup_in_class=False)
- # try soft delete the share
- self.assertRaises(lib_exc.Forbidden,
+ # NOTE(gouthamr): The client used below is of a member from alt
+ # project. As a fix to bug #1901210, the server responds with
+ # 404 instead of 403, but we'll test for one of the two codes since
+ # the test could be running against a release without the fix.
+ self.assertRaises((lib_exc.Forbidden, lib_exc.NotFound),
self.alt_shares_v2_client.soft_delete_share,
share['id'])
diff --git a/requirements.txt b/requirements.txt
index 95ad247..108bbee 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -4,6 +4,6 @@
pbr!=2.1.0,>=2.0.0 # Apache-2.0
-ddt>=1.0.1 # MIT
+ddt>=1.6.0 # MIT
oslo.log>=3.36.0 # Apache-2.0
tempest>=31.1.0 # Apache-2.0
diff --git a/zuul.d/manila-tempest-jobs.yaml b/zuul.d/manila-tempest-jobs.yaml
index 6f158e8..c7318af 100644
--- a/zuul.d/manila-tempest-jobs.yaml
+++ b/zuul.d/manila-tempest-jobs.yaml
@@ -57,11 +57,7 @@
timeout: 10800
irrelevant-files: *irrelevant-files
required-projects: *manila-tempest-required-projects
- vars:
- <<: *manila-tempest-base-vars
- # NOTE(gouthamr): Disabled until https://launchpad.net/bugs/1940324 is
- # fixed.
- tempest_exclude_regex: "(^manila_tempest_tests.tests.scenario.*IPv6.*)"
+ vars: *manila-tempest-base-vars
- job:
name: manila-tempest-plugin-standalone-base
@@ -178,7 +174,27 @@
- openstack/neutron-dynamic-routing
vars:
tempest_test_regex: '(^manila_tempest_tests.tests)(?=.*\[.*\bbackend\b.*\])'
+ devstack_services: &devstack-with-ovs
+ # NOTE(gouthamr): LP#1940324 prevents bgp usage with OVN, disable OVN
+ br-ex-tcpdump: false
+ br-int-flows: false
+ ovn-controller: false
+ ovn-northd: false
+ ovs-vswitchd: false
+ ovsdb-server: false
+ q-ovn-metadata-agent: false
+ # Neutron services
+ neutron-local-ip-static: true
+ q-agt: true
+ q-dhcp: true
+ q-l3: true
+ q-meta: true
+ q-metering: true
devstack_localrc:
+ # NOTE(gouthamr): LP#1940324 prevents bgp usage with OVN, use OVS
+ Q_AGENT: openvswitch
+ Q_ML2_TENANT_NETWORK_TYPE: vxlan
+ Q_ML2_PLUGIN_MECHANISM_DRIVERS: openvswitch
SHARE_DRIVER: manila.share.drivers.lvm.LVMShareDriver
MANILA_ENABLED_BACKENDS: london,paris
MANILA_BACKEND1_CONFIG_GROUP_NAME: london
@@ -368,7 +384,6 @@
enable_cephx_rules_for_protocols: cephfs
run_share_group_tests: false
multitenancy_enabled: false
- suppress_errors_in_cleanup: true
backend_names: CEPHFSNATIVE
capability_storage_protocol: CEPHFS
enable_protocols: cephfs
@@ -390,10 +405,15 @@
- openstack/neutron-dynamic-routing
vars:
tempest_concurrency: 2
+ devstack_services: *devstack-with-ovs # LP 1940324
devstack_plugins:
devstack-plugin-ceph: https://opendev.org/openstack/devstack-plugin-ceph
neutron-dynamic-routing: https://opendev.org/openstack/neutron-dynamic-routing
devstack_localrc:
+ # NOTE(gouthamr): LP#1940324 prevents bgp usage with OVN, use OVS
+ Q_AGENT: openvswitch
+ Q_ML2_TENANT_NETWORK_TYPE: vxlan
+ Q_ML2_PLUGIN_MECHANISM_DRIVERS: openvswitch
VOLUME_BACKING_FILE_SIZE: 60GB
SHARE_DRIVER: manila.share.drivers.cephfs.driver.CephFSDriver
MANILA_ENABLED_BACKENDS: cephfsnfs
@@ -420,7 +440,6 @@
run_ipv6_tests: true
run_share_group_tests: false
multitenancy_enabled: false
- suppress_errors_in_cleanup: true
backend_names: CEPHFSNFS
enable_protocols: nfs
capability_storage_protocol: NFS
diff --git a/zuul.d/manila-tempest-stable-jobs.yaml b/zuul.d/manila-tempest-stable-jobs.yaml
index 1b73d12..d5adfce 100644
--- a/zuul.d/manila-tempest-stable-jobs.yaml
+++ b/zuul.d/manila-tempest-stable-jobs.yaml
@@ -76,9 +76,7 @@
parent: manila-tempest-plugin-lvm-base
nodeset: openstack-single-node-focal
override-checkout: stable/yoga
- vars:
- tempest_exclude_regex: "(^manila_tempest_tests.tests.scenario.*IPv6.*)"
- <<: *manila_tempest_image_pinned_vars
+ vars: *manila_tempest_image_pinned_vars
- job:
name: manila-tempest-plugin-lvm-xena