Change assertTrue(isinstance()) by optimal assert
Some of tests use different method of assertTrue(isinstance(A, B)) or
assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
B) provided by testtools.
Change-Id: I9053c9deaa71ee12e10db73b19250b3a32f3d93c
Closes-bug: #1268480
diff --git a/manila_tempest_tests/tests/api/admin/test_share_servers.py b/manila_tempest_tests/tests/api/admin/test_share_servers.py
index 7cd67f8..c7eccb1 100644
--- a/manila_tempest_tests/tests/api/admin/test_share_servers.py
+++ b/manila_tempest_tests/tests/api/admin/test_share_servers.py
@@ -196,7 +196,7 @@
# share_network_name is not empty
self.assertTrue(len(server["share_network_name"]) > 0)
# backend_details should be a dict
- self.assertTrue(isinstance(server["backend_details"], dict))
+ self.assertIsInstance(server["backend_details"], dict)
@test.attr(type=["gate", "smoke", ])
def test_show_share_server_details(self):
@@ -205,8 +205,8 @@
servers[0]["id"])
# If details are present they and their values should be only strings
for k, v in details.iteritems():
- self.assertTrue(isinstance(k, six.string_types))
- self.assertTrue(isinstance(v, six.string_types))
+ self.assertIsInstance(k, six.string_types)
+ self.assertIsInstance(v, six.string_types)
@test.attr(type=["gate", "smoke", ])
def _delete_share_server(self, delete_share_network):