commit da7e045b2967e34f72bfb36fe43ee014a4e73791
author Vishakha Agarwal <agarwalvishakha18@gmail.com> Sat May 02 00:38:33 2020 +0530
committer Vishakha Agarwal <agarwalvishakha18@gmail.com> Fri May 15 07:10:23 2020 +0000
tree 47d9c047c2aaa180821c9f5e868c1208a4ce96e9
parent eedd37dc05bce6d95b0538ff36051fb09f9e3c2e

Add addCleanup just after resource creation

This patch follows the sequence of adding addCleanup
just after creating a resource similar to whole
keystone-tempest-plugin repo. This is to avoid the
resource leakage issue if anything happen between
resource creation and addcleanup line.

Change-Id: I258c440417eaecb8f5ed4dc1e0eb6138edda883b

keystone_tempest_plugin/tests/scenario/test_federated_authentication.py

diff --git a/keystone_tempest_plugin/tests/scenario/test_federated_authentication.py b/keystone_tempest_plugin/tests/scenario/test_federated_authentication.py
index b152116..e4c9d88 100644
--- a/keystone_tempest_plugin/tests/scenario/test_federated_authentication.py
+++ b/keystone_tempest_plugin/tests/scenario/test_federated_authentication.py
@@ -228,20 +228,19 @@
         project_id = self.keystone_manager.identity_providers_client.tenant_id
         group = self.keystone_manager.groups_client.create_group(
             name=data_utils.rand_uuid_hex(), domain_id=domain_id)
+        self.addCleanup(
+            self.keystone_manager.groups_client.delete_group,
+            group['group']['id'])
         role = self.keystone_manager.roles_v3_client.create_role(
             name=data_utils.rand_uuid_hex(), project_id=project_id)
-
+        self.addCleanup(
+            self.keystone_manager.roles_v3_client.delete_role,
+            role['role']['id'])
         self.keystone_manager.roles_v3_client.create_group_role_on_project(
             group_id=group['group']['id'], project_id=project_id,
             role_id=role['role']['id'])
         self.keystone_manager.groups_client.add_group_user(
             group_id=group['group']['id'], user_id=user_id)
-        self.addCleanup(
-            self.keystone_manager.groups_client.delete_group,
-            group['group']['id'])
-        self.addCleanup(
-            self.keystone_manager.roles_v3_client.delete_role,
-            role['role']['id'])
 
     def _setup_settings(self):
         super(TestK2KFederatedAuthentication, self)._setup_settings()