Add secure-rbac tests for Orders
This patch adds basic RBAC tests for the Orders resource for
the reader, member, and admin personas with project scope.
Change-Id: Ie5b7b6f7df20ec96e916232e70e9f61c7771f9d2
diff --git a/barbican_tempest_plugin/services/key_manager/json/order_client.py b/barbican_tempest_plugin/services/key_manager/json/order_client.py
index d7a3945..c81ddd0 100644
--- a/barbican_tempest_plugin/services/key_manager/json/order_client.py
+++ b/barbican_tempest_plugin/services/key_manager/json/order_client.py
@@ -11,19 +11,18 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
-
-
import json
-
from urllib import parse as urllib
from tempest import config
-from tempest.lib.common import rest_client
+
+from barbican_tempest_plugin.services.key_manager.json import base
+
CONF = config.CONF
-class OrderClient(rest_client.RestClient):
+class OrderClient(base.BarbicanTempestClient):
def list_orders(self, **kwargs):
uri = "/v1/orders"
diff --git a/barbican_tempest_plugin/services/key_manager/json/secret_client.py b/barbican_tempest_plugin/services/key_manager/json/secret_client.py
index dda4494..29a9cd0 100644
--- a/barbican_tempest_plugin/services/key_manager/json/secret_client.py
+++ b/barbican_tempest_plugin/services/key_manager/json/secret_client.py
@@ -17,17 +17,15 @@
import json
from tempest import config
-from tempest.lib.common import rest_client
from tempest.lib.common.utils import data_utils
+from barbican_tempest_plugin.services.key_manager.json import base
+
+
CONF = config.CONF
-class SecretClient(rest_client.RestClient):
-
- def __init__(self, *args, **kwargs):
- kwargs['service'] = 'key-manager'
- super().__init__(*args, **kwargs)
+class SecretClient(base.BarbicanTempestClient):
def create_secret(self, **kwargs):
if 'name' not in kwargs:
diff --git a/barbican_tempest_plugin/tests/rbac/v1/base.py b/barbican_tempest_plugin/tests/rbac/v1/base.py
index b16e431..6fe15a1 100644
--- a/barbican_tempest_plugin/tests/rbac/v1/base.py
+++ b/barbican_tempest_plugin/tests/rbac/v1/base.py
@@ -131,7 +131,7 @@
service='key-manager'
)
cls.container_client = os.secret_v1.ContainerClient()
- cls.order_client = os.secret_v1.OrderClient(service='key-manager')
+ cls.order_client = os.secret_v1.OrderClient()
cls.quota_client = os.secret_v1.QuotaClient(service='key-manager')
cls.secret_client = os.secret_v1.SecretClient()
cls.secret_metadata_client = os.secret_v1.SecretMetadataClient(
@@ -149,9 +149,7 @@
service='key-manager'
)
cls.admin_container_client = adm.secret_v1.ContainerClient()
- cls.admin_order_client = adm.secret_v1.OrderClient(
- service='key-manager'
- )
+ cls.admin_order_client = adm.secret_v1.OrderClient()
cls.admin_quota_client = adm.secret_v1.QuotaClient(
service='key-manager'
)
@@ -192,7 +190,7 @@
uuid = cls.ref_to_uuid(response['container_ref'])
if resource == 'order':
uuid = cls.ref_to_uuid(response.get('order_ref'))
- order_metadata = cls.get_order(uuid)
+ order_metadata = cls.admin_order_client.get_order(uuid)
secret_ref = order_metadata.get('secret_ref')
if secret_ref:
cls.created_objects['secret'].add(cls.ref_to_uuid(secret_ref))
diff --git a/barbican_tempest_plugin/tests/rbac/v1/test_orders.py b/barbican_tempest_plugin/tests/rbac/v1/test_orders.py
new file mode 100644
index 0000000..36f9a26
--- /dev/null
+++ b/barbican_tempest_plugin/tests/rbac/v1/test_orders.py
@@ -0,0 +1,186 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+import abc
+import time
+
+from tempest.lib import exceptions
+
+from barbican_tempest_plugin.tests.rbac.v1 import base
+
+
+class BarbicanV1RbacOrders:
+
+ @abc.abstractmethod
+ def test_list_orders(self):
+ """Test list_orders policy
+
+ Testing GET /v1/orders
+ This test must check:
+ * whether persona can list orders
+ """
+ raise NotImplementedError
+
+ @abc.abstractmethod
+ def test_create_order(self):
+ """Test create_order policy
+
+ Testing POST /v1/orders
+ This test must check:
+ * whether persona can create orders
+ """
+ raise NotImplementedError
+
+ @abc.abstractmethod
+ def test_get_order(self):
+ """Test get_order policy
+
+ Testing GET /v1/orders/{order-id}
+ This test must check:
+ * whether persona can get order information
+ """
+ raise NotImplementedError
+
+ @abc.abstractmethod
+ def test_delete_order(self):
+ """Test delete_order policy
+
+ Testing DELETE /v1/orders/{order-id}
+ This test must check:
+ * whether persona can delete orders
+ """
+ raise NotImplementedError
+
+
+class ProjectMemberTests(base.BarbicanV1RbacBase, BarbicanV1RbacOrders):
+
+ @classmethod
+ def setup_clients(cls):
+ super().setup_clients()
+ cls.client = cls.os_project_member.secret_v1.OrderClient()
+
+ def test_list_orders(self):
+ self.do_request('create_order', cleanup='order',
+ name='list_orders', type='key',
+ meta={
+ 'name': 'list_orders_s',
+ 'algorithm': 'aes',
+ 'bit_length': 256,
+ 'mode': 'cbc',
+ })
+ resp = self.do_request('list_orders')
+ self.assertGreaterEqual(len(resp['orders']), 1)
+
+ def test_create_order(self):
+ self.do_request('create_order', cleanup='order',
+ name='create_order', type='key',
+ meta={
+ 'name': 'create_orders_s',
+ 'algorithm': 'aes',
+ 'bit_length': 256,
+ 'mode': 'cbc',
+ })
+
+ def test_get_order(self):
+ resp = self.do_request('create_order', cleanup='order',
+ name='get_order', type='key',
+ meta={
+ 'name': 'get_order_s',
+ 'algorithm': 'aes',
+ 'bit_length': 256,
+ 'mode': 'cbc',
+ })
+ order_id = self.ref_to_uuid(resp['order_ref'])
+ resp = self.do_request('get_order', order_id=order_id)
+ self.assertEqual(order_id, self.ref_to_uuid(resp['order_ref']))
+
+ def test_delete_order(self):
+ resp = self.do_request('create_order',
+ name='delete_order', type='key',
+ meta={
+ 'name': 'delete_order_s',
+ 'algorithm': 'aes',
+ 'bit_length': 256,
+ 'mode': 'cbc',
+ })
+ order_id = self.ref_to_uuid(resp['order_ref'])
+ while True:
+ time.sleep(1)
+ resp = self.do_request('get_order', order_id=order_id)
+ if 'ACTIVE' == resp['status']:
+ self.add_cleanup('secret', resp)
+ break
+
+ self.do_request('delete_order', order_id=order_id)
+
+
+class ProjectAdminTests(ProjectMemberTests):
+
+ @classmethod
+ def setup_clients(cls):
+ super().setup_clients()
+ cls.client = cls.os_project_admin.secret_v1.OrderClient()
+
+
+class ProjectReaderTests(base.BarbicanV1RbacBase, BarbicanV1RbacOrders):
+
+ @classmethod
+ def setup_clients(cls):
+ super().setup_clients()
+ cls.client = cls.os_project_reader.secret_v1.OrderClient()
+
+ def test_list_orders(self):
+ self.do_request('list_orders', expected_status=exceptions.Forbidden)
+
+ def test_create_order(self):
+ self.do_request('create_order',
+ expected_status=exceptions.Forbidden,
+ cleanup='order',
+ name='create_order', type='key',
+ meta={
+ 'name': 'create_orders_s',
+ 'algorithm': 'aes',
+ 'bit_length': 256,
+ 'mode': 'cbc',
+ })
+
+ def test_get_order(self):
+ resp = self.do_request(
+ 'create_order',
+ client=self.os_project_member.secret_v1.OrderClient(),
+ cleanup='order',
+ name='get_order', type='key',
+ meta={
+ 'name': 'get_order_s',
+ 'algorithm': 'aes',
+ 'bit_length': 256,
+ 'mode': 'cbc',
+ }
+ )
+ order_id = self.ref_to_uuid(resp['order_ref'])
+ self.do_request('get_order', expected_status=exceptions.Forbidden,
+ order_id=order_id)
+
+ def test_delete_order(self):
+ resp = self.do_request(
+ 'create_order',
+ client=self.os_project_member.secret_v1.OrderClient(),
+ cleanup='order',
+ name='delete_order', type='key',
+ meta={
+ 'name': 'delete_order_s',
+ 'algorithm': 'aes',
+ 'bit_length': 256,
+ 'mode': 'cbc',
+ })
+ order_id = self.ref_to_uuid(resp['order_ref'])
+ self.do_request('delete_order', expected_status=exceptions.Forbidden,
+ order_id=order_id)