Remove wrong Gerrit plugin before service upgrade to 2019.2.6
Since Gerrit 2019.2.0, jar file for plugin download-command has incorrect
name and as a result was not loaded and strikes error during Gerrit start.
In new Gerrit version 2019.2.6 (2.15.17) issue was fixed and we need to
drop old jar file if still exists before upgrade.
Change-Id: I84cb3923590a5ad67d5c312f390ec5f48c5d18df
Related-Prod: PROD-33802
diff --git a/upgrade-mcp-release.groovy b/upgrade-mcp-release.groovy
index 8eebc46..dd5b971 100644
--- a/upgrade-mcp-release.groovy
+++ b/upgrade-mcp-release.groovy
@@ -613,6 +613,11 @@
// Apply changes for HaProxy on CI/CD nodes
salt.enforceState(venvPepper, 'I@keepalived:cluster:instance:cicd_control_vip and I@haproxy:proxy', 'haproxy.proxy', true)
+ // Gerrit 2019.2.0 (2.13.6) version has wrong file name for download-commands plugin and was not loaded, let's remove if still there before upgrade
+ def gerritGlusterPath = salt.getPillar(venvPepper, 'I@gerrit:client', 'glusterfs:client:volumes:gerrit:path').get('return')[0].values()[0]
+ def wrongPluginJarName = "${gerritGlusterPath}/plugins/project-download-commands.jar"
+ salt.cmdRun(venvPepper, 'I@gerrit:client', "test -f ${wrongPluginJarName} && rm ${wrongPluginJarName}")
+
salt.cmdRun(venvPepper, "I@salt:master", "salt -C 'I@jenkins:client and I@docker:client and not I@salt:master' state.sls docker.client --async")
sleep(180)