commit b266ad228d8a2604dd00ca5faa2c1b7bfd79b0bb
author azvyagintsev <azvyagintsev@mirantis.com> Tue Sep 11 12:11:11 2018 +0300
committer azvyagintsev <azvyagintsev@mirantis.com> Tue Sep 11 13:25:42 2018 +0300
tree c2946164eff3018cc579cdf193d7222ec58e522e
parent 0c97ffcfb8b7b367aa1d78e6e9e131dfd44b4991

Fix params passing

  * Fix passing params to sub-jobs
    and sub-job itself

Change-Id: I84e4fd3d66bc043489156517e7f25879e1dc3f08

test-cookiecutter-reclass.groovy

diff --git a/test-cookiecutter-reclass.groovy b/test-cookiecutter-reclass.groovy
index 8b0f776..daf9efe 100644
--- a/test-cookiecutter-reclass.groovy
+++ b/test-cookiecutter-reclass.groovy
@@ -24,6 +24,8 @@
 gerritConData = [credentialsId       : env.CREDENTIALS_ID,
                  gerritName          : env.GERRIT_NAME ?: 'mcp-jenkins',
                  gerritHost          : env.GERRIT_HOST ?: 'gerrit.mcp.mirantis.net',
+                 gerritScheme        : env.GERRIT_SCHEME ?: 'ssh',
+                 gerritPort          : env.GERRIT_PORT ?: '29418',
                  gerritRefSpec       : null,
                  gerritProject       : null,
                  withWipeOut         : true,
@@ -44,7 +46,7 @@
 // version of debRepos, aka formulas\reclass
 testDistribRevision = env.DISTRIB_REVISION ?: 'nightly'
 reclassVersion = 'v1.5.4'
-if (common.validInputParam(env.RECLASS_VERSION)) {
+if (env.RECLASS_VERSION) {
     reclassVersion = env.RECLASS_VERSION
 }
 // Name of sub-test chunk job
@@ -221,7 +223,7 @@
     // In general, simply make transition updates for non-master branch
     // based on magic logic
     def message = ''
-    if (!common.validInputParam(env.GERRIT_PROJECT)) {
+    if (env.GERRIT_PROJECT) {
         if (!['nightly', 'testing', 'stable', 'proposed', 'master'].contains(env.GERRIT_BRANCH)) {
             gerritDataCC['gerritBranch'] = env.GERRIT_BRANCH
             gerritDataRS['gerritBranch'] = env.GERRIT_BRANCH
@@ -255,10 +257,10 @@
         currentBuild.description = currentBuild.description ? message + "<br/>" + currentBuild.description : message
     } else {
         // Check for passed variables:
-        if (common.validInputParam(env.RECLASS_SYSTEM_GIT_REF)) {
+        if (env.RECLASS_SYSTEM_GIT_REF) {
             gerritDataRS['gerritRefSpec'] = RECLASS_SYSTEM_GIT_REF
         }
-        if (common.validInputParam(env.COOKIECUTTER_TEMPLATE_REF)) {
+        if (env.COOKIECUTTER_TEMPLATE_REF) {
             gerritDataCC['gerritRefSpec'] = COOKIECUTTER_TEMPLATE_REF
         }
         message = "<font color='red'>Manual run detected!</font>" + "<br/>"
@@ -310,7 +312,6 @@
         def reclassNodeInfoDir = "${env.WORKSPACE}/reclassNodeInfo_compare/"
         def reclassInfoHeadPath = "${reclassNodeInfoDir}/old"
         def reclassInfoPatchedPath = "${reclassNodeInfoDir}/new"
-
         try {
             sh(script: 'find . -mindepth 1 -delete > /dev/null || true')
             stage('Download and prepare CC env') {
@@ -371,7 +372,7 @@
                    tar -xzf ${headReclassArtifactName}  --directory ${compareRoot}/old
                    """)
                 common.warningMsg('infra/secrets.yml has been skipped from compare!')
-                result =  '\n' + common.comparePillars(compareRoot, env.BUILD_URL, "-Ev \'infra/secrets.yml\'")
+                result = '\n' + common.comparePillars(compareRoot, env.BUILD_URL, "-Ev \'infra/secrets.yml\'")
                 currentBuild.description = currentBuild.description ? currentBuild.description + result : result
             }
             stage("TestContexts Head/Patched") {