commit 80d45b23709005c9ca63136a0a8f3bf41d412f9c
author Denis Egorenko <degorenko@mirantis.com> Thu Jan 31 22:28:38 2019 +0400
committer Denis Egorenko <degorenko@mirantis.com> Fri Feb 01 15:16:24 2019 +0400
tree e27fb37817fe2c62fd4359f3606237cef25005dc
parent 42ea661cebe9d00e294ff75d191fc23d87de294e

Prevent test-wrapper from running backward compatibility tests on gate mode

Also drop redundant code for checking gate inside test-cookiecutter job, as
now it's checking in test-wrapper.

Change-Id: I227d52a8ecea4b587330370ecd695c377aca82e7

test-salt-model-wrapper.groovy

diff --git a/test-salt-model-wrapper.groovy b/test-salt-model-wrapper.groovy
index 4dfdcd8..b499db1 100644
--- a/test-salt-model-wrapper.groovy
+++ b/test-salt-model-wrapper.groovy
@@ -191,19 +191,20 @@
             if (gerritProject == reclassSystemRepo || gerritProject == cookiecutterTemplatesRepo) {
                 branchJobName = 'test-mk-cookiecutter-templates'
                 branches[branchJobName] = runTests(branchJobName, yamlJobParameters(buildTestParams))
+            }
+
+            if (!gateMode) {
                 // testing backward compatibility
                 if (gerritBranch == 'master' && gerritProject == reclassSystemRepo) {
                     def backwardCompatibilityRefsToTest = ['proposed', 'release/2018.11.0', 'release/2019.2.0']
                     for (String oldRef in backwardCompatibilityRefsToTest) {
-                        buildTestParams['COOKIECUTTER_TEMPLATE_REF'] = ''
-                        buildTestParams['COOKIECUTTER_TEMPLATE_BRANCH'] = oldRef
-                        threadName = "${branchJobName}-${oldRef}"
-                        branches[threadName] = runTests(branchJobName, yamlJobParameters(buildTestParams), threadName)
+                        LinkedHashMap buildTestParamsOld = buildTestParams.clone()
+                        buildTestParamsOld['COOKIECUTTER_TEMPLATE_REF'] = ''
+                        buildTestParamsOld['COOKIECUTTER_TEMPLATE_BRANCH'] = oldRef
+                        String threadName = "${branchJobName}-${oldRef}"
+                        branches[threadName] = runTests(branchJobName, yamlJobParameters(buildTestParamsOld), threadName)
                     }
                 }
-            }
-
-            if (!gateMode) {
                 if (gerritProject == cookiecutterTemplatesRepo) {
                     branchJobName = 'test-drivetrain'
                     branches[branchJobName] = runTests(branchJobName, yamlJobParameters(buildTestParams))