Add pre-upgrade verify pipeline
Move pre-upgrade checks to pipeline-library
PROD-36632
Change-Id: Ib5c0e17641ae94c1bdb1148f47c760a2bab0cad4
diff --git a/upgrade-mcp-release.groovy b/upgrade-mcp-release.groovy
index e2af7ec..25b8d61 100644
--- a/upgrade-mcp-release.groovy
+++ b/upgrade-mcp-release.groovy
@@ -29,6 +29,7 @@
def saltMastCreds = ''
def packageUpgradeMode = ''
batchSize = ''
+upgradeChecks = new com.mirantis.mcp.UpgradeChecks()
def fullRefreshOneByOne(venvPepper, minions) {
for (minion in minions) {
@@ -239,42 +240,6 @@
}
}
-def check_34406(String cluster_name) {
- def sphinxpasswordPillar = salt.getPillar(venvPepper, 'I@salt:master', '_param:sphinx_proxy_password_generated').get("return")[0].values()[0]
- if (sphinxpasswordPillar == '' || sphinxpasswordPillar == 'null' || sphinxpasswordPillar == null) {
- error('Sphinx password is not defined.\n' +
- 'See https://docs.mirantis.com/mcp/q4-18/mcp-release-notes/mu/mu-9/mu-9-addressed/mu-9-dtrain/mu-9-dt-manual.html#i-34406 for more info')
- }
-}
-
-def check_34645(String cluster_name) {
- def updatecellsPillar = salt.getPillar(venvPepper, 'I@nova:controller', 'nova:controller:update_cells').get("return")[0].values()[0]
- if (updatecellsPillar.toString().toLowerCase() == 'false') {
- error('Update cells disabled.\n' +
- 'See https://docs.mirantis.com/mcp/q4-18/mcp-operations-guide/openstack-operations/disable-nova-cell-mapping.html')
- }
-}
-
-def check_35705(String cluster_name) {
- def galeracheckpasswordPillar = salt.getPillar(venvPepper, 'I@salt:master', '_param:galera_clustercheck_password').get("return")[0].values()[0]
- if (galeracheckpasswordPillar == '' || galeracheckpasswordPillar == 'null' || galeracheckpasswordPillar == null) {
- error('Galera clustercheck password is not defined.\n' +
- 'See https://docs.mirantis.com/mcp/q4-18/mcp-release-notes/mu/mu-12/mu-12-addressed/mu-12-dtrain/mu-12-dt-manual.html#improper-operation-of-galera-ha for more info')
- }
-}
-
-def check_35884(String cluster_name) {
- if (salt.getMinions(venvPepper, 'I@prometheus:alerta or I@prometheus:alertmanager')) {
- def alertaApiKeyGenPillar = salt.getPillar(venvPepper, 'I@salt:master', '_param:alerta_admin_api_key_generated').get("return")[0].values()[0]
- def alertaApiKeyPillar = salt.getPillar(venvPepper, 'I@prometheus:alerta or I@prometheus:alertmanager', '_param:alerta_admin_key').get("return")[0].values()[0]
-
- if (alertaApiKeyGenPillar == '' || alertaApiKeyGenPillar == 'null' || alertaApiKeyGenPillar == null || alertaApiKeyPillar == '' || alertaApiKeyPillar == 'null' || alertaApiKeyPillar == null) {
- error('Alerta admin API key not defined.\n' +
- 'See https://docs.mirantis.com/mcp/q4-18/mcp-release-notes/mu/mu-12/mu-12-addressed/mu-12-dtrain/mu-12-dt-manual.html#i-35884 for more info')
- }
- }
-}
-
def wa32182(String cluster_name) {
if (salt.testTarget(venvPepper, 'I@opencontrail:control or I@opencontrail:collector')) {
def clusterModelPath = "/srv/salt/reclass/classes/cluster/${cluster_name}"
@@ -667,10 +632,12 @@
common.infoMsg('Perform: Full salt sync')
fullRefreshOneByOne(venvPepper, allMinions)
- check_34406(cluster_name)
- check_34645(cluster_name)
- check_35705(cluster_name)
- check_35884(cluster_name)
+ upgradeChecks.check_34406(salt, venvPepper, cluster_name, true)
+ upgradeChecks.check_34645(salt, venvPepper, cluster_name, true)
+ upgradeChecks.check_35705(salt, venvPepper, cluster_name, true)
+ upgradeChecks.check_35884(salt, venvPepper, cluster_name, true)
+ upgradeChecks.check_36461(salt, venvPepper, cluster_name, true)
+ upgradeChecks.check_36461_2(salt, venvPepper, cluster_name, true)
common.infoMsg('Perform: Validate reclass medata before processing')
validateReclassModel(minions, 'before')