tree 78f38a00bab8d5ea859e55c79da16dec3443172e
parent 9868358cfaac0bc92ec6ae38d9727d0db4c26c65
author Charles Duffy <chaduffy@cisco.com> 1474389722 -0500
committer Carlos Sanchez <carlos@apache.org> 1474902190 +0200

Avoid eval, shell-injection via JAVA_OPTS or JENKINS_OPTS

The intent of using eval when processing JAVA_OPTS or JENKINS_OPTS is to allow arguments with spaces to be passed through and parsed without the bugs given in [BashFAQ #50](http://mywiki.wooledge.org/BashFAQ/050). By using `eval`, however, the issues discussed in [BashFAQ #48](http://mywiki.wooledge.org/BashFAQ/048) are introduced.

Strings containing whitespace can be safely processed with `xargs`, which -- when not used with the non-POSIX extensions `-0` or `-d` -- follows shell quoting conventions in splitting its input stream into arguments.