commit 995f681ced301bb4acdcbd47559374747a95154b
author Niklaus Giger <niklaus.giger@member.fsf.org> Tue Sep 08 12:01:45 2015 +0200
committer Niklaus Giger <niklaus.giger@member.fsf.org> Tue Sep 08 12:01:45 2015 +0200
tree d56bacc0b887e60fe4deb40f9f1cd05dfbf9b42d
parent 9395d3fdd74cd43f03b1844fbb0c3e48d713cbc1

Verify that downloaded plugin is really a Zip archive

Dockerfile

diff --git a/Dockerfile b/Dockerfile
index 2d687f0..64d1fe3 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,6 +1,6 @@
 FROM java:8-jdk
 
-RUN apt-get update && apt-get install -y wget git curl zip && rm -rf /var/lib/apt/lists/*
+RUN apt-get update && apt-get install -y wget git curl zip file && rm -rf /var/lib/apt/lists/*
 
 ENV JENKINS_HOME /var/jenkins_home
 ENV JENKINS_SLAVE_AGENT_PORT 50000

plugins.sh

diff --git a/plugins.sh b/plugins.sh
index 3413ce4..f0285bb 100755
--- a/plugins.sh
+++ b/plugins.sh
@@ -24,4 +24,11 @@
       JENKINS_UC_DOWNLOAD=$JENKINS_UC/download
     fi
     curl -sSL -f ${JENKINS_UC_DOWNLOAD}/plugins/${plugin[0]}/${plugin[1]}/${plugin[0]}.hpi -o $REF/${plugin[0]}.jpi
+    if ls -l $REF/${plugin[0]}.jpi && file $REF/${plugin[0]}.jpi | grep 'Zip archive'
+    then
+      echo Download okay. ${plugin[0]}.jpi seems to be a Zip archive
+    else
+      echo "Downloading via '${cmd}' failed"
+      exit 3
+    fi
 done  < $1