Updates on error logging and handling
- iterative error log storage
- config like value storage
- updates logging format for improved readablility
Change-Id: I171a1b44452c1225340a7d7b1f7593ab9b8ce7c2
Related-PROD: PROD-28199
diff --git a/cfg_checker/modules/network/checker.py b/cfg_checker/modules/network/checker.py
index aeb1e61..48e7acb 100644
--- a/cfg_checker/modules/network/checker.py
+++ b/cfg_checker/modules/network/checker.py
@@ -10,7 +10,9 @@
class NetworkChecker(SaltNodes):
def __init__(self):
+ logger_cli.info("# Gathering environment information")
super(NetworkChecker, self).__init__()
+ logger_cli.info("# Initializing error logs folder")
self.errors = NetworkErrors()
# adding net data to tree
@@ -375,27 +377,15 @@
)
def print_summary(self):
- _total_errors = self.errors.get_errors_total()
- # Summary
- logger_cli.info(
- "\n{:=^8s}\n{:^8s}\n{:=^8s}".format(
- "=",
- "Totals",
- "="
- )
- )
logger_cli.info(self.errors.get_summary(print_zeros=False))
- logger_cli.info('-'*20)
- logger_cli.info("{:5d} total errors found\n".format(_total_errors))
def print_error_details(self):
# Detailed errors
- if self.errors.get_errors_total() > 0:
- logger_cli.info("\n# Errors")
- for _msg in self.errors.get_errors_as_list():
- logger_cli.info("{}\n".format(_msg))
- else:
- logger_cli.info("-> No errors\n")
+ logger_cli.info(
+ "\n{}\n".format(
+ self.errors.get_errors()
+ )
+ )
def create_html_report(self, filename):
"""