Updated todoes
Change-Id: I43707d38f31791ac770b09c277fd99bf4a74c8fc
diff --git a/rsync_remote.py b/rsync_remote.py
index 91aeebb..f448faa 100644
--- a/rsync_remote.py
+++ b/rsync_remote.py
@@ -27,6 +27,7 @@
# TODO: locking:
# https://review.openstack.org/#/c/147120/4/utils/simple_http_daemon.py
# create lock-files on remotes during operations
+ # symlink dir-timestamp.lock -> dir-timestamp
# for reading and writing
# special option for ignore lock-files (for manual fixing)
# all high-level functions (like ls) specify type of lock(read or
@@ -34,7 +35,6 @@
# also _do_rsync uses retry for waiting wnen resource will be unlocked
# TODO: check for url compatibility (local->remote, remote->local,
# local->local)
- # TODO: push method - upstream mirrors
dest = self.url.urljoin(dest)
allextra = self.rsync_extra_params
if extra is not None:
diff --git a/trsync.py b/trsync.py
index 3dcbdd6..c38cf9b 100644
--- a/trsync.py
+++ b/trsync.py
@@ -30,9 +30,7 @@
class TRsync(RsyncRemote):
- # retry and other function with mirror
- # add all the needed directory functions here, like mkdir, ls, rm etc
- # possible check that rsync url is exists
+ # TODO: possible check that rsync url is exists
def __init__(self,
rsync_url,
snapshot_dir='snapshots',
@@ -53,7 +51,6 @@
self.init_directory_structure()
def init_directory_structure(self):
- # TODO: self.rsyncRemote.mkdir
if self.url.url_type != 'path':
server_root = RsyncRemote(self.url.root)
return server_root.mkdir(
@@ -79,8 +76,6 @@
self.url.a_file(self.url.path, latest_path)
)
- # TODO: retry on base class!!!!!!!!!!!!!!!
- # TODO: locking - symlink dir-timestamp.lock -> dir-timestamp
# TODO: split transaction run (push or pull), and
# commit/rollback functions. transaction must has possibility to
# rollback after commit for implementation of working with pool