commit 73d62141b805690773534ce207c754bf671c5f9c
author Jakub Josef <jakub.josef@gmail.com> Wed Mar 29 17:07:18 2017 +0200
committer Jakub Josef <jakub.josef@gmail.com> Wed Mar 29 17:07:18 2017 +0200
tree 46922f01449a62864be3fd6e5a14d393bad5a804
parent d383f3929cb7e83f54fbd2c0ea0f861beef7c845

Improved gerrit checkout config checking

Change-Id: I93cc8b2e462a538b012a19d8b308f494a75e2495

src/com/mirantis/mk/Gerrit.groovy

diff --git a/src/com/mirantis/mk/Gerrit.groovy b/src/com/mirantis/mk/Gerrit.groovy
index 5c5c575..bb6438e 100644
--- a/src/com/mirantis/mk/Gerrit.groovy
+++ b/src/com/mirantis/mk/Gerrit.groovy
@@ -97,8 +97,11 @@
             }
         }
         return true
+    }else{
+        def common = new com.mirantis.mk.Common()
+        common.errorMsg("Cannot perform gerrit checkout, given config file is not valid")
+        return false
     }
-    return false
 }
 /**
  * Execute git clone and checkout stage from gerrit review
@@ -136,9 +139,10 @@
 }
 
 def _validGerritConfig(LinkedHashMap config){
-    return config.get("gerritScheme","") != "" &&
-           config.get("gerritName","") != "" &&
-           config.get("gerritHost","") != "" &&
-           config.get("gerritPort","") != "" &&
-           config.get("gerritProject","") != ""
+    return config.get("gerritScheme","") != null && config.get("gerritScheme","") != "" &&
+           config.get("gerritName","") != null && config.get("gerritName","") != "" &&
+           config.get("gerritHost","") != null && config.get("gerritHost","") != "" &&
+           config.get("gerritPort","") != null && config.get("gerritPort","") != "" &&
+           config.get("gerritProject","") != null && config.get("gerritProject","") != "" &&
+           config.get("gerritRefSpec","") != null && config.get("gerritRefSpec","") != ""
 }
\ No newline at end of file