Merge "[eqv2] Select metro based on current cloud instances availability - clarifying output for metro"
diff --git a/src/com/mirantis/mcp/UpgradeChecks.groovy b/src/com/mirantis/mcp/UpgradeChecks.groovy
index c9b0192..54d00f6 100644
--- a/src/com/mirantis/mcp/UpgradeChecks.groovy
+++ b/src/com/mirantis/mcp/UpgradeChecks.groovy
@@ -138,18 +138,67 @@
}
def check_36461_2 (salt, venvPepper, String cluster_name, Boolean raise_exc) {
- def cephMonPillar = salt.getPillar(venvPepper, 'I@ceph:mon', 'ceph:common:config:mon:auth_allow_insecure_global_id_reclaim').get("return")[0].values()[0]
- def cephVersion = salt.getPillar(venvPepper, 'I@ceph:mon', 'ceph:common:version').get("return")[0].values()[0]
- def waStatus = [prodId: "PROD-36461_2", isFixed: "", waInfo: ""]
- if (cephMonPillar.toString().toLowerCase() != 'false' && cephVersion.toString().toLowerCase() == 'nautilus') {
+ def saltTarget = salt.getFirstMinion(venvPepper, 'I@ceph:mon')
+ def cephVersionNum = salt.cmdRun(venvPepper, saltTarget, "ceph version | awk '{print \$3}'").get('return')[0].values()[0].replaceAll('Salt command execution success', '').trim()
+ List cephVersion = cephVersionNum.tokenize('.')
+
+ def majorVersion = cephVersion[0].toInteger()
+ def minorVersion = cephVersion[1].toInteger()
+ def minorSubversion = cephVersion[2].toInteger()
+
+ def waStatus = [prodId: "PROD-36461,PROD-36942", isFixed: "", waInfo: ""]
+
+ def allowInsecureReclaimIdPillar = salt.getPillar(venvPepper, 'I@ceph:mon', 'ceph:common:config:mon:auth_allow_insecure_global_id_reclaim').get("return")[0].values()[0]
+ allowInsecureReclaimIdPillar = allowInsecureReclaimIdPillar.toString().toLowerCase().trim()
+
+ if (majorVersion >= 14 && minorVersion >= 2 && minorSubversion >= 20) {
+ if ( allowInsecureReclaimIdPillar == 'false' ){
+ waStatus.isFixed = "Installed ceph version is 14.2.20+ and insecure global reclaim_id is disabled. Nothing to do."
+ return waStatus
+ }
waStatus.isFixed = "Work-around should be applied manually"
- waStatus.waInfo = "See https://docs.mirantis.com/mcp/q4-18/mcp-release-notes/single/index.html#i-cve-2021-20288 for more info"
+ waStatus.waInfo = "Ceph is vulnerable for CVE-2021-20288. See https://docs.mirantis.com/mcp/q4-18/mcp-release-notes/single/index.html#i-cve-2021-20288 for more info"
if (raise_exc) {
- error('Needed option is not set.\n' +
- waStatus.waInfo)
+ error('Option is not set to required value.\n' + waStatus.waInfo)
}
return waStatus
}
- waStatus.isFixed = "Work-around for PROD-36461_2 already applied, nothing todo"
+
+ if ( allowInsecureReclaimIdPillar == 'false' ) {
+ waStatus.isFixed = "Work-around should be applied manually"
+ waStatus.waInfo = "To upgrade ceph from version below 14.2.20 you MUST set ceph:common:config:mon:auth_allow_insecure_global_id_reclaim pillar to \"true\"."
+ if (raise_exc) {
+ error('Option is not set to required value.\n' + waStatus.waInfo)
+ }
+ return waStatus
+ }
+ return waStatus
+}
+
+def check_36960 (salt, venvPepper, String cluster_name, Boolean raise_exc) {
+ def waStatus = [prodId: "PROD-36960", isFixed: "", waInfo: ""]
+
+ if (!salt.testTarget(venvPepper, 'I@redis:server')) {
+ waStatus.isFixed = 'Nothing to do. There are no redis-servers.'
+ return waStatus
+ }
+
+ def redisVersionPillar = salt.getPillar(venvPepper, 'I@redis:server', 'redis:server:version').get("return")[0].values()[0]
+
+ List redisVersion = redisVersionPillar.toString().tokenize('.')
+
+ def majorVersion = redisVersion[0].toInteger()
+ def minorVersion = redisVersion[1].toInteger()
+
+ if (majorVersion >= 5 && minorVersion >= 0) {
+ waStatus.isFixed = 'Nothing to do. Redis-server version pillar is set to required version (5.0+).'
+ return waStatus
+ }
+ waStatus.isFixed = "Fix should be applied manually"
+ waStatus.waInfo = """To apply latest MU to openstack control plane you MUST set correct version for redis-server package. \n
+Please set pillar "redis:server:version" to "5.0" to openstack/telemetry.yml and refresh pillars."""
+ if (raise_exc) {
+ error('Option is not set to required value.\n' + waStatus.waInfo)
+ }
return waStatus
}
diff --git a/src/com/mirantis/mk/KaasUtils.groovy b/src/com/mirantis/mk/KaasUtils.groovy
index 7f42992..f680e9f 100644
--- a/src/com/mirantis/mk/KaasUtils.groovy
+++ b/src/com/mirantis/mk/KaasUtils.groovy
@@ -153,7 +153,6 @@
equinixOnDemandDemo = true
equinixMetalV2OnDemandDemo = true
runUie2e = true
- equinixMetalV2Metro = 'sv'
// Edit after fix PRODX-3961
enableBMDemo = false
}
@@ -1113,17 +1112,34 @@
def metalUrl = "https://artifactory.mcp.mirantis.net:443/artifactory/binary-dev-kaas-local/core/bin/mirror/metal-${version}-linux"
def metros = []
def out = ''
+ def retries = 10 // number of retries
+ def i = 0
+ def delay = 60 // 1 minute sleep
try {
sh "curl -o metal -# ${metalUrl} && chmod +x metal"
withCredentials([string(credentialsId: env.KAAS_EQUINIX_API_TOKEN, variable: 'KAAS_EQUINIX_API_TOKEN')]) {
sh 'echo "project-id: ${KAAS_EQUINIX_PROJECT_ID}\ntoken: ${KAAS_EQUINIX_API_TOKEN}" >metal.yaml'
- out = sh(script: "./metal --config metal.yaml capacity get -m -P ${nodeType}|awk '/${nodeType}/ {print \$2}'|paste -s -d,|xargs ./metal --config metal.yaml capacity check -P ${nodeType} -q ${nodeCount} -m|grep true|awk '{print \$2}'|paste -s -d,", returnStdout: true).trim()
- sh 'rm metal.yaml'
}
- metros = out.tokenize(',')
+ common.infoMsg("Selecting available Equinix metro with free ${nodeCount} ${nodeType} hosts")
+ while (metros.size() == 0 && i < retries) {
+ common.infoMsg("Try ${i+1}/${retries} ...")
+ if (i > 0 ) { // skip sleep on first step
+ sleep(delay)
+ }
+ out = sh(script: "./metal --config metal.yaml capacity get -m -P ${nodeType}|awk '/${nodeType}/ {print \$2}'|paste -s -d,|xargs ./metal --config metal.yaml capacity check -P ${nodeType} -q ${nodeCount} -m|grep true|awk '{print \$2}'|paste -s -d,", returnStdout: true).trim()
+ metros = out.tokenize(',')
+ i++
+ }
} catch (Exception e) {
common.errorMsg "Exception: '${e}'"
return []
+ } finally {
+ sh 'rm metal.yaml'
+ }
+ if (metros.size() > 0) {
+ common.infoMsg("Selected metros: ${metros}")
+ } else {
+ common.warningMsg('No any metros have been selected !!! :(')
}
return metros
}