Add dryrun flag to welcome_message.py
In order to test this properly, we need a way to specify
not to post the message. This patch adds a new flag "--dryrun"
which will prevent the invocation of the method that posts
the message.
Minor logging changes were made to ensure we can still get info
about what's going on when in dry run mode.
Change-Id: I5cdb00bf89a1a83d70d03ec4a2ca7aae7651b4b3
diff --git a/jeepyb/cmd/welcome_message.py b/jeepyb/cmd/welcome_message.py
index 31df892..03278cc 100644
--- a/jeepyb/cmd/welcome_message.py
+++ b/jeepyb/cmd/welcome_message.py
@@ -60,6 +60,7 @@
data = cursor.fetchone()
if data:
if data[0] == "1":
+ logger.info('We found a newbie: %s', uploader)
return True
else:
return False
@@ -131,11 +132,15 @@
# for Welcome Message
parser.add_argument('user', help='The gerrit admin user')
parser.add_argument('ssh_key', help='The gerrit admin SSH key file')
+ # Don't actually post the message
+ parser.add_argument('--dryrun', dest='dryrun', action='store_true')
+ parser.add_argument('--no-dryrun', dest='dryrun', action='store_false')
+ parser.set_defaults(dryrun=False)
args = parser.parse_args()
# they're a first-timer, post the message on 1st patchset
- if is_newbie(args.uploader) and args.patchset == 1:
+ if is_newbie(args.uploader) and args.patchset == 1 and not args.dryrun:
post_message(args.change, args.user, args.ssh_key)
if __name__ == "__main__":