Fix logic in doc impact
Previous patch was supposed to update notify_impact
so that doc impact flags only triggered bugs on change
merge. This worked, however the branch logic was flawed,
meaning that non-merging changes now trigger emails.
This patch fixes for the desired behaviour
Change-Id: I3b028319c026bce84d4641e417aed9e8e0f52063
diff --git a/jeepyb/cmd/notify_impact.py b/jeepyb/cmd/notify_impact.py
index 0f81b1c..af1ad8a 100644
--- a/jeepyb/cmd/notify_impact.py
+++ b/jeepyb/cmd/notify_impact.py
@@ -85,8 +85,9 @@
For non-documentation impacts at all states of merge
notify the mailing list of impact.
"""
- if args.impact.lower() == 'docimpact' and args.hook == "change-merged":
- create_bug(git_log, args, 'openstack-manuals')
+ if args.impact.lower() == 'docimpact':
+ if args.hook == "change-merged":
+ create_bug(git_log, args, 'openstack-manuals')
return
email_content = EMAIL_TEMPLATE % (args.impact,