Make all Python pass pyflakes
This found one bug, but will also help us with Jenkins testing of these scripts
Change-Id: Iabe171645c06f769957db7cf0def1d10a0e47988
diff --git a/close_pull_requests.py b/close_pull_requests.py
index 0355e90..64160ed 100755
--- a/close_pull_requests.py
+++ b/close_pull_requests.py
@@ -29,7 +29,6 @@
import github2.client
import os
-import StringIO
import ConfigParser
import logging
import re
diff --git a/expire_old_reviews.py b/expire_old_reviews.py
index 1ba936e..f9e908a 100644
--- a/expire_old_reviews.py
+++ b/expire_old_reviews.py
@@ -18,7 +18,6 @@
# 1. if open and no activity in 2 weeks, expire
# 2. if negative comment and no activity in 1 week, expire
-import os
import paramiko
import json
import logging
diff --git a/fetch_remotes.py b/fetch_remotes.py
index 19df462..7948c74 100755
--- a/fetch_remotes.py
+++ b/fetch_remotes.py
@@ -20,16 +20,13 @@
# remote = https://gerrit.googlesource.com/gerrit
import ConfigParser
-import StringIO
import logging
import os
import re
import subprocess
-
+import shlex
def run_command(cmd, status=False, env={}):
- if VERBOSE:
- print datetime.datetime.now(), "Running:", cmd
cmd_list = shlex.split(str(cmd))
newenv = os.environ
newenv.update(env)
diff --git a/update_cla_group.py b/update_cla_group.py
index 91365a2..d418cf0 100755
--- a/update_cla_group.py
+++ b/update_cla_group.py
@@ -16,15 +16,9 @@
# Add launchpad ids listed in the wiki CLA page to the CLA group in LP.
import os
-import sys
-import uuid
-import os
import urllib
import re
-import StringIO
-import ConfigParser
-
from launchpadlib.launchpad import Launchpad
from launchpadlib.uris import LPNET_SERVICE_ROOT
diff --git a/update_gerrit_users.py b/update_gerrit_users.py
index 68ac448..15baaa9 100755
--- a/update_gerrit_users.py
+++ b/update_gerrit_users.py
@@ -19,7 +19,6 @@
import sys
import fcntl
import uuid
-import os
import subprocess
from datetime import datetime
@@ -42,6 +41,9 @@
DEBUG = False
+# suppress pyflakes
+pkg_resources.get_supported_platform()
+
pid_file = '/tmp/update_gerrit_users.pid'
fp = open(pid_file, 'w')
try:
diff --git a/update_users.py b/update_users.py
index 5ff654b..b40fbfd 100644
--- a/update_users.py
+++ b/update_users.py
@@ -19,6 +19,7 @@
# 2. split out the two classes into separate files to be used as a library
import os
+import sys
import ConfigParser
import StringIO
import paramiko
@@ -301,7 +302,7 @@
user_ssh_keys= ["%s %s %s" % ('ssh-%s' % key.keytype.lower(), key.keytext, key.comment) for key in user_data.sshkeys]
user_email= None
try:
- email = user_data.preferred_email_address.email
+ user_email = user_data.preferred_email_address.email
except ValueError:
pass
query= "insert into account_id (s) values (NULL)"